Repository navigation
Preserve Git command failure statuses - #352
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
status_helper now runs the printf/sed formatter only when Git produced output, so an empty status contributes zero bytes instead of one newline while the saved Git status code and nonempty formatting stay unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Related to #251 and #307; these targeted status fixes do not resolve hook failure policy or dynamic default-branch detection.
Validation and limits
Generated the vcsh script from the exact vcsh.in source (configure substitution) and ran isolated Git-backed consumer checks: clean named-repository status emits zero bytes (one newline before the last commit), a dirty repository keeps the existing formatted output byte-for-byte unchanged, and a real Git status failure (corrupt HEAD) propagates exit 128. Shell syntax check and git diff --check passed.
The Perl/prove suite and full project suite were not run, and no build, install or CI execution was performed. These are isolated fixtures, not acceptance against real user dotfiles.