TypeScript CodeGeneration checks AllowAdditionalProperties#1412
Merged
RicoSuter merged 1 commit intoSep 16, 2022
Merged
Conversation
|
@RicoSuter is that something that can be merged? |
Owner
|
Thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code generation for TypeScript doesn't currently respect the AllowAdditionalProperties or AdditionalPropertiesSchema values. Current template code already has relevant syntax when HasIndexerProperty is set to true. HasIndexerProperty is only referenced by the Liquid template and is only used in ways that allows for additional properties in classes/interfaces, so I simply modified the getter for HasIndexerProperty to check the additional properties