Skip to content

Fix output of JsonIgnore attributes#1522

Merged
RicoSuter merged 6 commits into
RicoSuter:masterfrom
AroglDarthu:nswag-issue-4012
Aug 15, 2022
Merged

Fix output of JsonIgnore attributes#1522
RicoSuter merged 6 commits into
RicoSuter:masterfrom
AroglDarthu:nswag-issue-4012

Conversation

@AroglDarthu

Copy link
Copy Markdown
Contributor

Attempt to fix RicoSuter/NSwag#4012
I'm not entirely certain on how to find out if the property is a value type.
Please have a look and tell me what you think.

Comment thread src/NJsonSchema.CodeGeneration.CSharp/Models/PropertyModel.cs Outdated
Comment thread src/NJsonSchema.CodeGeneration.CSharp/Models/PropertyModel.cs Outdated
@HavenDV

HavenDV commented Jul 13, 2022

Copy link
Copy Markdown

I think you need to delete ValueTypeFormats

@AroglDarthu AroglDarthu reopened this Jul 13, 2022
@AroglDarthu

AroglDarthu commented Jul 13, 2022

Copy link
Copy Markdown
Contributor Author

@RicoSuter any thoughts from you on this one? It kind of prevents people that use System.Text.Json (like myself) from using versions above 13.15.10

@binginsin

Copy link
Copy Markdown
Contributor

@RicoSuter could you please have a look? This is still a serious issue and is causing problems, would be good to get this merged in.

@RicoSuter RicoSuter merged commit b4d81b0 into RicoSuter:master Aug 15, 2022
@RicoSuter

Copy link
Copy Markdown
Owner

Lgtm, thanks for the Pr.

@abrasat

abrasat commented Aug 18, 2022

Copy link
Copy Markdown

@RicoSuter Could you please update the nuget packages with this fix?

@bdovaz

bdovaz commented Sep 3, 2022

Copy link
Copy Markdown

We need a NuGet package update, please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ignore condition 'JsonIgnoreCondition.WhenWritingNull' is not valid on value-type member

7 participants