Fix SystemTextJson read only properties handling#1697
Merged
RicoSuter merged 1 commit intoJun 12, 2024
Conversation
|
I just ran into the same problem and wanted to raise the same PR as a fix :) Nice job! Hope it get's merged soon! |
Owner
|
thanks for the PR. |
This was referenced Oct 16, 2025
This was referenced Oct 24, 2025
This was referenced Nov 4, 2025
This was referenced Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SystemTextJsonReflectionServicedidn't properly handle when a setter (or getter) was missing. As a result read-only private properties and read-only static properties were not ignored when building type schema via reflection.Fixes #1694