Skip to content

Fix TypeMapper UseReference not used when mapping a GenericType#1762

Merged
lahma merged 1 commit into
RicoSuter:masterfrom
desjoerd:fix/generic-type-mapper-use-reference
Jan 8, 2025
Merged

Fix TypeMapper UseReference not used when mapping a GenericType#1762
lahma merged 1 commit into
RicoSuter:masterfrom
desjoerd:fix/generic-type-mapper-use-reference

Conversation

@desjoerd

@desjoerd desjoerd commented Dec 2, 2024

Copy link
Copy Markdown
Contributor

When using Generic TypeMappers the UseReference property was not used. This causes problems when using primitives (and string) which do not use references.

fixes #1302
fixes #1046

@desjoerd

desjoerd commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

It should also fix #1046

@desjoerd

desjoerd commented Dec 2, 2024

Copy link
Copy Markdown
Contributor Author

Please let me know if you want me to fix anything, I was doubting a bit on the test, on whether it's clear enough.

@desjoerd

Copy link
Copy Markdown
Contributor Author

@RicoSuter did you have time to take a look at this? Let me know if I need to change anything or add more unit tests 🙂

@desjoerd desjoerd force-pushed the fix/generic-type-mapper-use-reference branch from b1f850d to 3b4e3ad Compare January 7, 2025 07:58
@desjoerd

desjoerd commented Jan 7, 2025

Copy link
Copy Markdown
Contributor Author

I was reviewing my code and I had some weird changes in the unit test. I fixed those. Hopefully it's now good to merge 👍

@desjoerd

desjoerd commented Jan 7, 2025

Copy link
Copy Markdown
Contributor Author

@lahma was this #1766 the problem with the build?

@lahma

lahma commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator

Yes I believe so. Full framework expected mono to be installed and it is not in new ubuntu 24.04 runners.

@desjoerd

desjoerd commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

Can you requeue the checks? Because I don't see the option. It would be really nice to have this PR merged, and maybe released together with the package updates.

@lahma

lahma commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator

If you merge latest master to this branch there's a chance for build to succeed.

@desjoerd desjoerd force-pushed the fix/generic-type-mapper-use-reference branch from 3b4e3ad to 814c101 Compare January 8, 2025 09:21
@desjoerd

desjoerd commented Jan 8, 2025

Copy link
Copy Markdown
Contributor Author

I rebased, but github doesn't queue the PR build automatically. The workflow is awaiting approval.

@lahma lahma merged commit 6b85e07 into RicoSuter:master Jan 8, 2025
@lahma

lahma commented Jan 8, 2025

Copy link
Copy Markdown
Collaborator

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please support PrimitiveTypeMappers for generic types Type mapping a generic class to the wrapped type

2 participants