Fix patternProperties validation to apply to all properties#1898
Merged
lahma merged 1 commit intoMar 7, 2026
Conversation
patternProperties was only validated against additional properties (those not in the schema's properties collection). Per JSON Schema spec, patternProperties should be evaluated against all object properties. Fixes RicoSuter#1736 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 8, 2026
Merged
This was referenced May 21, 2026
This was referenced May 29, 2026
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patternPropertiesvalidation was only applied to additional properties (not in the schema'spropertiescollection), but the JSON Schema spec requires it to be evaluated against all object propertiesValidatePatternPropertiesto receive all properties for validation, while still correctly removing matched properties from the additional properties list foradditionalPropertiesevaluationTest plan
PatternPropertyValidationTests.cs:Fixes #1736
🤖 Generated with Claude Code