Set up v12 integration branch#1924
Merged
Merged
Conversation
- Add docs/v12.md describing the v12 scope, branch model, development workflow with NSwag v15, release plan, and pre-release cleanup checklist - Add v12 to OnPullRequestBranches / OnPushBranches in Build.CI.GitHubActions.cs and the regenerated workflow YAMLs so CI runs on the v12 branch and on PRs targeting it (revert before v12 merges to master)
- New docs/changelog_v12.md tracks landed changes and v11 → v12 migration guidance per breaking change (with placeholder sections for planned PRs #1914, #1917, SchemaType expansion, reference-resolution fixes) - docs/v12.md "Running changelog" section replaced with a pointer to the dedicated file - Plan vs changelog separation: v12.md describes process (scope, branches, release plan, cleanup), changelog_v12.md is the user-facing record
Plan doc and changelog are now visually paired by filename: - docs/plan_v12.md - docs/changelog_v12.md Update internal cross-references in both files.
3 tasks
CLAUDE.md: - Project Overview, Cross-check with NSwag (supported spec targets table, 5-point cross-check checklist, reviewer prompt, link to references.md) - Build Commands, Architecture, Testing, Code Style - Git Rules: no AI attribution in commits / PRs / comments docs/references.md: - Comprehensive reference on ActualSchema vs ActualTypeSchema vs InheritedSchema, the resolution algorithm, and cross-spec behavior - DocumentPath / external ref resolution; $id, $anchor, $dynamicRef non-support limitations - NSwag's OpenApiParameter.ActualSchema override mechanics - Sibling-keyword gaps (the "Case C" problem), generalized beyond const - Known limitations grouped by theme; decision matrix for consumers
… to clarify sibling-keyword handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Starter PR that sets up the
v12integration branch for the major v12 release. Establishes the plan document and makes CI run againstv12.docs/v12.mdcovering:v12branch and PRs against it are actually built/tested:build/Build.CI.GitHubActions.cs:v12added toOnPullRequestBranchesandOnPushBranches.github/workflows/build.yml,pr.yml: regenerated with the same additionOpen PRs #1914 and #1917 are already retargeted to
v12and will start receiving CI once this merges.Test plan
v12, thepr.ymltrigger will start firing for subsequent PRs againstv12)nuke --generate-configuration GitHubActions_build --host GitHubActionsdoesn't revert the change)Companion
NSwag v15 gets the equivalent starter PR separately — adds
docs/v15.mdand its v15 branch CI triggers plus the sibling NJsonSchema checkout step.