Skip to content

Fix empty enumerable parameter handling in C# client #5222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 1 commit into from
Jul 26, 2025
Merged

Fix empty enumerable parameter handling in C# client #5222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions ...apshots/ArrayParameterTests.When_CollectionFormat_is_csv_then_do_not_explode.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,21 @@ namespace MyNamespace
urlBuilder_.Append('?');
if (elementId != null)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId") + "=");
bool isAfterFirst = false;
foreach (var item_ in elementId)
{
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(",");
if (!isAfterFirst)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId")).Append('=');
}
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(',');
isAfterFirst = true;
}
if (isAfterFirst)
{
urlBuilder_.Length--;
urlBuilder_.Append('&');
}
urlBuilder_.Length--;
urlBuilder_.Append("&");
}
urlBuilder_.Length--;

Expand Down
16 changes: 12 additions & 4 deletions ...terTests.When_explode_is_false_then_do_not_explode_explode=-explode-- false,.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,21 @@ namespace MyNamespace
urlBuilder_.Append('?');
if (elementId != null)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId") + "=");
bool isAfterFirst = false;
foreach (var item_ in elementId)
{
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(",");
if (!isAfterFirst)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId")).Append('=');
}
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(',');
isAfterFirst = true;
}
if (isAfterFirst)
{
urlBuilder_.Length--;
urlBuilder_.Append('&');
}
urlBuilder_.Length--;
urlBuilder_.Append("&");
}
urlBuilder_.Length--;

Expand Down
16 changes: 12 additions & 4 deletions ...lode_is_false_then_do_not_explode_explode=-style-- -form-, -explode-- false,.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,21 @@ namespace MyNamespace
urlBuilder_.Append('?');
if (elementId != null)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId") + "=");
bool isAfterFirst = false;
foreach (var item_ in elementId)
{
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(",");
if (!isAfterFirst)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId")).Append('=');
}
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(',');
isAfterFirst = true;
}
if (isAfterFirst)
{
urlBuilder_.Length--;
urlBuilder_.Append('&');
}
urlBuilder_.Length--;
urlBuilder_.Append("&");
}
urlBuilder_.Length--;

Expand Down
16 changes: 12 additions & 4 deletions ...Snapshots/ArrayParameterTests.When_parameter_is_array_then_CSharp_is_correct.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,13 +77,21 @@ namespace MyNamespace
urlBuilder_.Append('?');
if (elementId != null)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId") + "=");
bool isAfterFirst = false;
foreach (var item_ in elementId)
{
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(",");
if (!isAfterFirst)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId")).Append('=');
}
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(',');
isAfterFirst = true;
}
if (isAfterFirst)
{
urlBuilder_.Length--;
urlBuilder_.Append('&');
}
urlBuilder_.Length--;
urlBuilder_.Append("&");
}
urlBuilder_.Length--;

Expand Down
16 changes: 12 additions & 4 deletions .../Snapshots/ParameterTests.When_parameter_is_array_and_should_not_be_exploded.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,21 @@ namespace MyNamespace
urlBuilder_.Append('?');
if (bar != null)
{
urlBuilder_.Append(System.Uri.EscapeDataString("foo") + "=");
bool isAfterFirst = false;
foreach (var item_ in bar)
{
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(",");
if (!isAfterFirst)
{
urlBuilder_.Append(System.Uri.EscapeDataString("foo")).Append('=');
}
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(',');
isAfterFirst = true;
}
if (isAfterFirst)
{
urlBuilder_.Length--;
urlBuilder_.Append('&');
}
urlBuilder_.Length--;
urlBuilder_.Append("&");
}
urlBuilder_.Length--;

Expand Down
16 changes: 12 additions & 4 deletions .../ParameterTests.When_parent_parameters_have_same_kind_then_they_are_included.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,21 @@ namespace MyNamespace
urlBuilder_.Append('?');
if (elementId != null)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId") + "=");
bool isAfterFirst = false;
foreach (var item_ in elementId)
{
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(",");
if (!isAfterFirst)
{
urlBuilder_.Append(System.Uri.EscapeDataString("elementId")).Append('=');
}
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(',');
isAfterFirst = true;
}
if (isAfterFirst)
{
urlBuilder_.Length--;
urlBuilder_.Append('&');
}
urlBuilder_.Length--;
urlBuilder_.Append("&");
}
urlBuilder_.Length--;

Expand Down
16 changes: 12 additions & 4 deletions src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.QueryParameter.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,21 @@ urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}")).Append('
{% elsif parameter.IsExplodedArray -%}
foreach (var item_ in {{ parameter.VariableName }}) { urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}")).Append('=').Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append('&'); }
{% elsif parameter.IsArray -%}
urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}") + "=");
bool isAfterFirst = false;
foreach (var item_ in {{ parameter.VariableName }})
{
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(",");
if (!isAfterFirst)
{
urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}")).Append('=');
}
urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(',');
isAfterFirst = true;
}
if (isAfterFirst)
{
urlBuilder_.Length--;
urlBuilder_.Append('&');
}
urlBuilder_.Length--;
urlBuilder_.Append("&");
{% elsif parameter.IsDictionary -%}
foreach (var item_ in {{ parameter.VariableName }}) { urlBuilder_.Append(System.Uri.EscapeDataString(item_.Key)).Append('=').Append(System.Uri.EscapeDataString(ConvertToString(item_.Value, System.Globalization.CultureInfo.InvariantCulture))).Append('&'); }
{% elsif parameter.IsDeepObject -%}
Expand Down
Loading