Broken autoload when in vendor/bin

[ciaranmcnulty]

I installed this on a project that doesn't have a specified bin-dir

> vendor/bin/roave-backward-compatibility-check 
PHP Fatal error:  Uncaught RuntimeException: Could not find Composer autoload.php in /my/project/vendor/roave/backward-compatibility-check/bin/roave-backward-compatibility-check.php:292

Debugging the loop in roave-backward-compatibility-check.php it's searching the following locations:

/my/project/vendor/roave/backward-compatibility-check/bin/../vendor/autoload.php
/my/project/vendor/roave/backward-compatibility-check/bin/../autoload.php

Of course neither contain the project deps because they're all higher up in /my/project/vendor

We tackle the similar issue in phpspec by also looking at paths relative to getcwd() but it's not that great a solution.

At the least, you can document that bin-dir needs to exist and it needs to be one dir below the project root

[Ocramius]

By default, bin-dir exists and defaults to vendor/bin: what is your composer.json like?

Also, I can see that this will further fail due to vendor not being in a standard location, and that will cause dependencies to not be found when the static analysis steps are actually run.

[ciaranmcnulty]

sorry, I meant I hadn't overridden it (https://github.com/phpspec/phpspec/blob/master/composer.json) - I'm executing it from vendor/bin/roave-backward-compatibility-check

[Ocramius]

Can you attempt a standalone installation of the tool and then running it from the phpspec cwd for now?

[Ocramius]

And yep, will fix in a few 👌

[ciaranmcnulty]

If I do a complete separate checkout, run composer update, and run it when cd to my other project, then it executes (I get a different error I'll try and debug, to do with how it executes git)

Note that composer global install also won't work currently:

> composer global require roave/backward-compatibility-check
[...]
> ~/.composer/vendor/bin/roave-backward-compatibility-check 
PHP Fatal error:  Uncaught RuntimeException: Could not find Composer autoload.php in [~]/.composer/vendor/roave/backward-compatibility-check/bin/roave-backward-compatibility-check.php:289

[Ocramius]

Aye, I think we never tried/throught of it as a dependency. Sending a patch within today 👌

…

On Sun, 27 May 2018, 10:58 Ciaran McNulty, ***@***.***> wrote: If I do a complete separate checkout, run composer update there, then it executes (I get a different error I'll try and debug, to do with how it executes git) Note that composer global install also won't work currently: > composer global require roave/backward-compatibility-check [...] > ~/.composer/vendor/bin/roave-backward-compatibility-check PHP Fatal error: Uncaught RuntimeException: Could not find Composer autoload.php in [~]/.composer/vendor/roave/backward-compatibility-check/bin/roave-backward-compatibility-check.php:289 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakN4Ie6VhMlOoG4gh5I9cgcFjcv_Uks5t2mrNgaJpZM4UPMov> .

[ciaranmcnulty]

It might be worth adding a couple of smoke tests for different install methods?

I poked around some other tools

https://github.com/phpactor/phpactor/blob/develop/bin/phpactor#L11-L12
https://github.com/sebastianbergmann/phpunit/blob/master/phpunit#L30

Nobody seems to agree on the search path, and people with weird bin-dir or vendor-dir are going to have a bad time in all cases :-/

Maybe this is why PHAR is the future

[Ocramius]

Until PHAR installation goes through a lock/SAT mechanism and namespace scoping, it will be generally avoided on my side.

…

On Sun, 27 May 2018, 11:04 Ciaran McNulty, ***@***.***> wrote: It might be worth adding a couple of smoke tests for different install methods? I poked around some other tools https://github.com/phpactor/phpactor/blob/develop/bin/phpactor#L11-L12 https://github.com/sebastianbergmann/phpunit/blob/master/phpunit#L30 Nobody seems to agree on the search path, and people with weird bin-dir or vendor-dir are going to have a bad time in all cases :-/ Maybe this is why PHAR is the future — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#70 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakNYPSmEarHFrppeBUDcHsrdm4lieks5t2mw6gaJpZM4UPMov> .

[Ocramius]

Handled in #71