Run api-compare via CLI #15
Conversation
|
Note: some tests are missing, and |
| /** @var Change[] */ | ||
| private $changes = []; | ||
|
|
||
| private function __construct() |
There was a problem hiding this comment.
What is the purpose of a private constructor in this case?
| { | ||
| } | ||
|
|
||
| public static function new(): self |
There was a problem hiding this comment.
I agree. It does not capture any meaningful value here.
There was a problem hiding this comment.
There are two ways to construct this:
::new()::fromArray()
Fully qualifies having static named constructors here to avoid potential BC breaks in the future
There was a problem hiding this comment.
Hmm, That is a valid point and I guess it also follows the "conventions" of the project.
|
|
||
| final class ApiCompare extends Command | ||
| { | ||
| /** @var PerformCheckoutOfRevision */ |
There was a problem hiding this comment.
Oh, yeh the CS will eventually be this (non-expanded)
|
|
||
| final class Changes implements IteratorAggregate | ||
| { | ||
| /** @var Change[] */ |
| { | ||
| /** @var Change $change */ | ||
| foreach ($changes as $change) { | ||
| $this->output->writeln((string)$change); |
There was a problem hiding this comment.
Nice idea; I'll add an issue but not bothering here
| ->with(sprintf('[BC] REMOVED: %s', $change1Text)); | ||
| $output->expects(self::at(1)) | ||
| ->method('writeln') | ||
| ->with(sprintf(' ADDED: %s', $change2Text)); |
src/Command/ApiCompare.php
Outdated
| $fromPath = $this->git->checkout($sourceRepo, Revision::fromSha1($input->getArgument('from'))); | ||
| $toPath = $this->git->checkout($sourceRepo, Revision::fromSha1($input->getArgument('to'))); | ||
|
|
||
| // @todo fix hard-coded /src/ addition... |
|
Tests added and passing; no longer WIP and ready for review & merge |
… into feature/provide-object-api-for-changes
Prototype here for running via CLI.
Usage currently like:
Note: this is a VERY rough around the edges initial implementation, and doesn't satisfy all our requirements yet (from #13). For example it doesn't do revision parsing (so it has to be full revision at the moment).