Skip to content

Upgrade dependencies, replace beberlei/assert with webmozart/assert, upgrade CS ruleset #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 22, 2020
Merged

Upgrade dependencies, replace beberlei/assert with webmozart/assert, upgrade CS ruleset #252

merged 8 commits into from
Jun 22, 2020

Conversation

Ocramius
Copy link
Member

@Ocramius Ocramius commented Jun 22, 2020 •
edited
Loading

Fixes #232
Fixes #243
Fixes #200

dependabot-preview bot and others added 8 commits June 22, 2020 11:43
@dependabot-preview @Ocramius
Bump squizlabs/php_codesniffer from 3.5.4 to 3.5.5
cdbe06f 
Bumps [squizlabs/php_codesniffer](https://github.com/squizlabs/PHP_CodeSniffer) from 3.5.4 to 3.5.5.
- [Release notes](https://github.com/squizlabs/PHP_CodeSniffer/releases)
- [Commits](squizlabs/PHP_CodeSniffer@3.5.4...3.5.5)

Signed-off-by: dependabot-preview[bot] <[email protected]>
@Ocramius
Require PHP 7.4 as minimum supported PHP release
868aeb6
@Ocramius
Require PHP 7.4 as minimum supported PHP release
ec9192b
@Ocramius
Upgraded to PHP 7.4 typed properties
25fcc2e
@Ocramius
Require at least PHP 7.4.7, which has working yield from construct …
a97ee71 
…(previous version broke it)

See https://bugs.php.net/bug.php?id=79657 - that was completely breaking this library
@Ocramius
Dropped phpstan dependency, upgraded symfony/console to ^5
b826679
@Ocramius
Replaced beberlei/assert with the more type-friendly `webmozart/ass…
6d6fd81 
…ert`
@Ocramius
Upgraded to newest doctrine/coding-standard, closer to PSR-12
e4399dd
@Ocramius Ocramius added this to the 5.0.0 milestone Jun 22, 2020
@Ocramius Ocramius self-assigned this Jun 22, 2020
Ocramius
Ocramius commented Jun 22, 2020
View reviewed changes
test/e2e/Command/AssertBackwardsCompatibleTest.php
@@ -184,7 +184,7 @@ public function testWillNotRunWithoutTagsNorSpecifiedVersions() : void
$this->sourcesRepository
);

self::assertSame(212, $check->run());
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a transient BC break coming from symfony/console - nothing to do about it though, as the code 212 was not supposed to be relied upon.

@Ocramius
Copy link
Member Author

BC breaks in this patch are expected:

[BC] CHANGED: The parameter $mergeArgs of Symfony\Component\Console\Command\Command#mergeApplicationDefinition() changed from no type to a non-contravariant bool

[BC] CHANGED: The parameter $name of Symfony\Component\Console\Command\Command#addArgument() changed from no type to a non-contravariant string

[BC] CHANGED: The parameter $mode of Symfony\Component\Console\Command\Command#addArgument() changed from no type to a non-contravariant ?int

[BC] CHANGED: The parameter $description of Symfony\Component\Console\Command\Command#addArgument() changed from no type to a non-contravariant string

[BC] CHANGED: The parameter $name of Symfony\Component\Console\Command\Command#addOption() changed from no type to a non-contravariant string

[BC] CHANGED: The parameter $mode of Symfony\Component\Console\Command\Command#addOption() changed from no type to a non-contravariant ?int

[BC] CHANGED: The parameter $description of Symfony\Component\Console\Command\Command#addOption() changed from no type to a non-contravariant string

[BC] CHANGED: The parameter $name of Symfony\Component\Console\Command\Command#setName() changed from no type to a non-contravariant string

[BC] CHANGED: The parameter $title of Symfony\Component\Console\Command\Command#setProcessTitle() changed from no type to a non-contravariant string

[BC] CHANGED: The parameter $hidden of Symfony\Component\Console\Command\Command#setHidden() changed from no type to a non-contravariant bool

[BC] CHANGED: The parameter $description of Symfony\Component\Console\Command\Command#setDescription() changed from no type to a non-contravariant string

[BC] CHANGED: The parameter $help of Symfony\Component\Console\Command\Command#setHelp() changed from no type to a non-contravariant string

[BC] CHANGED: The parameter $aliases of Symfony\Component\Console\Command\Command#setAliases() changed from no type to a non-contravariant iterable

[BC] CHANGED: The parameter $short of Symfony\Component\Console\Command\Command#getSynopsis() changed from no type to a non-contravariant bool

[BC] CHANGED: The parameter $usage of Symfony\Component\Console\Command\Command#addUsage() changed from no type to a non-contravariant string

[BC] CHANGED: The parameter $name of Symfony\Component\Console\Command\Command#getHelper() changed from no type to a non-contravariant string

@Ocramius Ocramius merged commit 8a3d4a3 into master Jun 22, 2020
@Ocramius Ocramius deleted the feature/dependency-upgrades branch June 22, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgrim asgrim asgrim approved these changes

Assignees

@Ocramius Ocramius

Labels
bc break enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Library broken on PHP 7.4.6 Drop PHP 7.3 support
2 participants
@Ocramius @asgrim