Constant removal, visibility reduction and value change detection #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
approved these changes
Apr 15, 2018
akrabat
reviewed
Apr 15, 2018
| { | ||
| Assert::that($fromClass->getName())->same($toClass->getName()); | ||
|
|
||
| $removedMethods = array_diff_key( |
There was a problem hiding this comment.
Should be $removedConstants?
There was a problem hiding this comment.
Aye: sending fixup PR in a jiffy
Ocramius
added a commit
that referenced
this pull request
Apr 15, 2018
Ocramius
added a commit
that referenced
this pull request
Apr 15, 2018
Ocramius
added a commit
that referenced
this pull request
Apr 15, 2018
`array_keys()` already produces a packed array
Ocramius
added a commit
that referenced
this pull request
Apr 15, 2018
akrabat
added a commit
that referenced
this pull request
Apr 16, 2018
uzibhalepu
added a commit
to uzibhalepu/BackwardCompatibilityCheck
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.