Skip to content

Add phpcs and phpstan #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 15, 2018
Merged

Add phpcs and phpstan #36

merged 8 commits into from
Apr 15, 2018

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Apr 15, 2018

Fixes #18

@asgrim asgrim added this to the 0.0.1 milestone Apr 15, 2018
@asgrim asgrim requested review from akrabat and Ocramius April 15, 2018 16:47
phpcs.xml.dist Outdated
<file>./test/unit</file>

<rule ref="Doctrine">
<exclude name="SlevomatCodingStandard.Classes.SuperfluousAbstractClassNaming"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be kept

phpcs.xml.dist Outdated

<rule ref="Doctrine">
<exclude name="SlevomatCodingStandard.Classes.SuperfluousAbstractClassNaming"/>
<exclude name="SlevomatCodingStandard.Classes.SuperfluousInterfaceNaming"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be kept

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 🚢 🚅 🚀 💯

@asgrim asgrim force-pushed the feature/doctrine-cs branch from 40f3eaf to 0436da3 Compare April 15, 2018 20:06
@Ocramius Ocramius merged commit a33dc33 into master Apr 15, 2018
@Ocramius Ocramius deleted the feature/doctrine-cs branch April 15, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants