Skip to content

Fixed Markdown output not returning skipped items #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

asgrim
Copy link
Member

@asgrim asgrim commented Jan 3, 2022

I noticed a discrepancy between the number of BC changes detected, and the number written in the markdown output formatter on a project:

# Added

# Changed
 - [BC] Value of constant Twig\Environment::VERSION changed from '3.3.0' to '3.3.4'
 - [BC] Value of constant Twig\Environment::VERSION_ID changed from 30300 to 30304
 - [BC] Value of constant Twig\Environment::RELEASE_VERSION changed from 0 to 4

# Removed

21 backwards-incompatible changes detected

This does NOT happen when using the console formatter:

[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Scoutapm\ScoutApmBundle\Twig\TwigMethods" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Scoutapm\ScoutApmBundle\Twig\TwigMethods" could not be found in the located source
[BC] CHANGED: Value of constant Twig\Environment::VERSION changed from '3.3.0' to '3.3.4'
[BC] CHANGED: Value of constant Twig\Environment::VERSION_ID changed from 30300 to 30304
[BC] CHANGED: Value of constant Twig\Environment::RELEASE_VERSION changed from 0 to 4
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Scoutapm\ScoutApmBundle\Twig\TwigMethods" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Scoutapm\ScoutApmBundle\Twig\TwigMethods" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
[BC] SKIPPED: Roave\BetterReflection\Reflection\ReflectionClass "Symfony\Component\HttpKernel\Event\FilterControllerEvent" could not be found in the located source
21 backwards-incompatible changes detected

@asgrim asgrim added the bug label Jan 3, 2022
@asgrim asgrim force-pushed the fix-missing-skipped-from-markdown-output branch from 8a00f92 to 3abb3c9 Compare January 3, 2022 11:25
@asgrim
Copy link
Member Author

asgrim commented Jan 3, 2022

@Ocramius note: I targeted the 6.0.x with this fix, as I think it's probably a "bug" with the current \Roave\BackwardCompatibility\Formatter\MarkdownPipedToSymfonyConsoleFormatter implementation.

@asgrim asgrim requested a review from Ocramius January 3, 2022 11:27
@asgrim asgrim added this to the 6.0.1 milestone Jan 3, 2022
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@@ -52,6 +52,10 @@
"sort-packages": true,
"platform": {
"php": "8.0.99"
},
"allow-plugins": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, we should really leave these out :D

I'll let it pass - will probably drop them again in future

@Ocramius Ocramius merged commit 7658d00 into 6.0.x Jan 3, 2022
@Ocramius Ocramius changed the title [6.0.x] Fixed Markdown output not returning skipped items Fixed Markdown output not returning skipped items Jan 3, 2022
@Ocramius Ocramius deleted the fix-missing-skipped-from-markdown-output branch January 3, 2022 11:43
@Ocramius
Copy link
Member

Ocramius commented Jan 3, 2022

Thanks @asgrim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants