Normalize __DIR__ and __FILE__ by changing the base path of LocatedSource instances, prevent false-positive BC breaks on those magic constants
#476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2022
…the base path of `LocatedSource` instances This fails due to `CompileNodeToValue()` internally using `realpath()` and `dirname()` operations, which both depend on the current filesystem: as it currently stands, this requires an improvement of `roave/better-reflection` first. Also, `ReplaceSourcePathOfLocatedSources` and `LocatedSourceWithStrippedSourcesDirectory` are extending `@internal` symbols, so we may want to first make these symbols public in `roave/better-reflection`, to avoid the BC boundary to become too relaxed, and therefore causing crashes if we (rightfully) decide to change `roave/better-reflection` internals. Fixes #400 Fixes #410
This contains Roave/BetterReflection#1043, which allows us to use `__DIR__` and `__FILE__` even if the real file locations were omitted/changed by the source locator.
…placeSourcePathOfLocatedSources` This goes in great detail to test every corner of these hacky overrides, making sure that we don't accidentally introduce incompatibilities with the parent implementation, since we have to use inheritance for this design.
Ocramius
force-pushed
the
fix/#400-#410-normalize-source-paths-to-prevent-__DIR__-and-__FILE__-bc-break-false-positives
branch
from
dd3e94b to
b124173
Compare
|
@asgrim this is (IMO) ready for review |
Ocramius
changed the title
__DIR__ and __FILE__ by changing the base path of LocatedSource instances__DIR__ and __FILE__ by changing the base path of LocatedSource instances
Ocramius
changed the title
__DIR__ and __FILE__ by changing the base path of LocatedSource instances__DIR__ and __FILE__ by changing the base path of LocatedSource instances, prevent false-positive BC breaks on those magic constants
asgrim
approved these changes
Mar 23, 2022
|
🚢 then, thanks for the review, @asgrim! |
Ocramius
deleted the
fix/#400-#410-normalize-source-paths-to-prevent-__DIR__-and-__FILE__-bc-break-false-positives
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fails due to
CompileNodeToValue()internally usingrealpath()anddirname()operations, which both dependon the current filesystem: as it currently stands, this requires an improvement of
roave/better-reflectionfirst.Also,
ReplaceSourcePathOfLocatedSourcesandLocatedSourceWithStrippedSourcesDirectoryare extending@internalsymbols, so we may want to first make these symbols public in
roave/better-reflection, to avoid the BC boundary tobecome too relaxed, and therefore causing crashes if we (rightfully) decide to change
roave/better-reflectioninternals.Fixes #400
Fixes #410
TODO
CompileNodeToValuesemi-@psalm-immutable? BetterReflection#1043