Skip to content

Handle invalid version strings gracefully #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2018
Merged

Handle invalid version strings gracefully #56

merged 1 commit into from
Apr 28, 2018

Conversation

ntzm
Copy link
Contributor

@ntzm ntzm commented Apr 28, 2018

No description provided.

@Ocramius Ocramius self-assigned this Apr 28, 2018
@Ocramius Ocramius added this to the 0.0.1 milestone Apr 28, 2018
Ocramius
Ocramius approved these changes Apr 28, 2018
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement, thanks! 👍

@Ocramius Ocramius merged commit 5d33fd3 into Roave:master Apr 28, 2018
@ntzm ntzm deleted the handle-invalid-versions branch April 29, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ntzm @Ocramius