Filter out anonymous classes #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asgrim
force-pushed
the
feature/filter-anon-classes
branch
from
d2aac7f to
5f4deee
Compare
Ocramius
approved these changes
May 4, 2018
| function (Changes $changes, FunctionBased $check) use ($fromFunction, $toClass) : Changes { | ||
| return $changes->mergeWith($check->__invoke($fromFunction, $toClass)); | ||
| function (Changes $changes, FunctionBased $check) use ($fromFunction, $toFunction) : Changes { | ||
| return $changes->mergeWith($check->__invoke($fromFunction, $toFunction)); |
There was a problem hiding this comment.
Is there a way to detect anonymous functions BTW?
There was a problem hiding this comment.
See description:
Note: the issue specifies filtering out anonymous functions too, but we don't actually reflect on functions at all at the moment; it is all just
ClassBased,InterfaceBasedandTraitBasedroots; plus the top level is theCompareClassesimplementation...
There was a problem hiding this comment.
Yes, ai was just wondering on whether we have these facilities in BR
There was a problem hiding this comment.
new FunctionReflector(/* stuff */)->getAllFunctions() exists, so I don't see why not 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55
Note: the issue specifies filtering out anonymous functions too, but we don't actually reflect on functions at all at the moment; it is all just
ClassBased,InterfaceBasedandTraitBasedroots; plus the top level is theCompareClassesimplementation...