Upgrade to latest BetterReflection version #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
commented
May 10, 2018
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| namespace RoaveTest\BackwardCompatibility\Support; | |||
|
|
|||
| use PHPStan\Testing\TestCase; | |||
| use PHPUnit\Framework\TestCase; | |||
There was a problem hiding this comment.
This had slipped in and I noticed it only after removing phpstan
Ocramius
force-pushed
the
feature/better-reflection-v4
branch
from
5c28fcf to
8a7843a
Compare
|
🚢 🚢 🚢 Too bad about infection and phpstan, but for now at least I managed to add psalm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
master(no changes incomposer.jsonthough, just lock file)Marked as WIP since I don't think excluding this stuff is a good idea, considering that phpstan is being released soon-ish...