Skip to content

100 % mutation score #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2023
Merged

100 % mutation score #1320

merged 4 commits into from
Feb 4, 2023

Conversation

kukulich
Copy link
Collaborator

No description provided.

@Ocramius Ocramius added this to the 6.6.0 milestone Dec 16, 2022
@kukulich kukulich force-pushed the mutants branch 3 times, most recently from 41c2304 to 0f8b177 Compare December 16, 2022 13:50
@kukulich
Copy link
Collaborator Author

kukulich commented Feb 3, 2023

And again one new mutant remaining.

@kukulich kukulich changed the title Kill the last not covered mutant 100 % mutation score Feb 4, 2023
@kukulich
Copy link
Collaborator Author

kukulich commented Feb 4, 2023

I've just added ignore for this last mutant. I don't know what I should change and how to test it. And I really want to merge this PR and unblock dependencies upgrades 😄

Warning: Escaped Mutant for Mutator "FalseValue":

--- Original
+++ New
@@ @@
     public function stream_open($path, $mode, $options, &$opened_path) : bool
     {
         self::$autoloadLocatedFile = $path;
-        return false;
+        return true;

@kukulich kukulich marked this pull request as ready for review February 4, 2023 09:00
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kukulich !

@Ocramius Ocramius self-assigned this Feb 4, 2023
@Ocramius Ocramius merged commit 0fe5e21 into Roave:6.6.x Feb 4, 2023
@kukulich kukulich deleted the mutants branch February 4, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants