Added build for PHP 7.2 to Travis #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: build failing at the moment as xdebug is not available on the build environment yet. |
|
MWOP suggested this approach, tho that wouldn't help with Humbug unless we disable Humbug where xdebug not available |
|
Not worth testing without humbug, IMO: it can wait until release.
Marco Pivetta
http://twitter.com/Ocramius
http://ocramius.github.com/
…On Mon, Aug 14, 2017 at 7:17 PM, James Titcumb ***@***.***> wrote:
MWOP suggested this approach
<https://github.com/zendframework/zend-expressive-hal/blob/master/.travis.yml#L42>,
tho that wouldn't help with Humbug unless we disable Humbug where xdebug
not available
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakFpMe3BBoB5ozWRK-ceRSmkpflPiks5sYIEdgaJpZM4O2o8z>
.
|
|
@asgrim rebase also needed |
|
Newer PHPUnit version needed: https://travis-ci.org/Roave/DoctrineSimpleCache/jobs/264439014#L235 |
Merged
asgrim
force-pushed
the
enable-support-for-php72
branch
from
96f1883 to
674a8d7
Compare
|
Green 💚 |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it says on the tin.