Skip to content

allow PHP 7.3 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019
Merged

allow PHP 7.3 #31

merged 1 commit into from
Jan 24, 2019

Conversation

mimmi20
Copy link
Contributor

@mimmi20 mimmi20 commented Jan 22, 2019

This PR intends to allow PHP 7.3 for this library and the use of build stages on travis.

This PR may replace PR #30.

@mimmi20 mimmi20 changed the title allow PHP 7.3+ allow PHP 7.3 Jan 22, 2019
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides last nitpicks, looks good! @asgrim wanna check?

@Ocramius Ocramius added this to the 2.2.0 milestone Jan 22, 2019
Copy link
Member

@asgrim asgrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mimmi20

@asgrim asgrim merged commit 1ad494f into Roave:master Jan 24, 2019
@asgrim asgrim mentioned this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants