Skip to content

Fix issues that prevent dependabot updates #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2021

Conversation

weirdan
Copy link
Contributor

@weirdan weirdan commented Mar 16, 2021

Rationale for each separate change is provided in a corresponding commit message.

This should unblock automatic updates that were failing because of Psalm / tests issues.

weirdan added 3 commits March 16, 2021 23:48
Before 4.5.0 Psalm would usually emit exit code 1 when it identified
issues, but this was undocumented. 4.5.0+ emits exit code 2, so to be
compatible with both variants we just expect a non-zero status instead.
In 4.5.0 Psalm changed the way it outputs some types in error messages.
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @weirdan! 👍

@Ocramius Ocramius added the bug Something isn't working label Mar 17, 2021
@Ocramius Ocramius self-assigned this Mar 17, 2021
@Ocramius Ocramius added this to the 1.9.1 milestone Mar 17, 2021
@Ocramius Ocramius merged commit 83a9bfc into Roave:1.9.x Mar 17, 2021
@weirdan weirdan deleted the allow-upgrades branch March 17, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants