Fix getUUID
and URIUtil
re-exports
#183
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getUUID
andURIUtil
are default exports, you need to use theexport * as …
syntax to re-exports them.As noted in #136 which made this (incorrect) change, those 2 exports never worked and do not appear in type definitions, so maybe the correct fix is to remove them entirely?
I spotted this by using https://microsoft.github.io/rnx-kit/docs/tools/metro-serializer-esbuild in my project, which uses
esbuild
to optimise the bundle code, and it error-ed because of this invalid export.This PR fixes the issue when tested locally with my setup, but again those 2 exports probably never worked so I dont think anybody used them.