Skip to content

Fix download issue with file size 2GB+ #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix download issue with file size 2GB+ #409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions android/src/main/java/com/ReactNativeBlobUtil/Response/ReactNativeBlobUtilFileResp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,19 @@ public MediaType contentType() {

@Override
public long contentLength() {
if (originalBody.contentLength() > Integer.MAX_VALUE) {

/**
*
* Okio buffer issue in current version seems to be fixed in the latest versions
*
* limiting this was causing the download progress to stop at 2GB size but files still was downloading
*
*/

// if (originalBody.contentLength() > Integer.MAX_VALUE) {
// This is a workaround for a bug Okio buffer where it can't handle larger than int.
return Integer.MAX_VALUE;
}
// return Integer.MAX_VALUE;
// }
return originalBody.contentLength();
}

Expand Down