-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Adding nebius provider to roocode #3807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding nebius provider to roocode #3807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @arafatkatze, Thank you for your contribution!
I left a couple of points that would be great to address before we proceed with your PR.
I also noticed that the translations are missing, but I can probably help you with that later.
Let me know if you have any questions or want to discuss my suggestions further!
|
||
const computerModels = Array.from(COMPUTER_USE_MODELS) | ||
|
||
// Process the model info from the response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we use Zod to validate the API response like we do with OpenRouter? This would let us know if the structure of the data changes in the future and make the code more robust against unexpected API responses. Currently, if the API returns a different structure, the code might silently fail or produce incorrect results.
src/api/providers/nebius.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new provider probably could use have some tests, you could use the OpenRouter ones as a base for this. Tests would help ensure the provider works correctly and catches any regressions in the future.
@daniel-lxs Thanks for the message. I might not have the bandwidth to fix all of those ideas. |
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
- Fix typo in Nebius component (was using litellmApiKey) - Fix inconsistent default base URL between UI and API handler - Add Zod validation for Nebius API responses - Add comprehensive unit tests for Nebius provider and fetcher - Improve error handling with schema validation
5a02fc1
to
0d38b54
Compare
I created a new PR for this #4116 |
Related GitHub Issue
cline#2789
Closes: #
Description
This PR adds nebius provider to roocode
Test Procedure
Type of Change
src
or test files.Pre-Submission Checklist
npm run lint
).console.log
) has been removed.npm test
).main
branch.npm run changeset
if this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Adds Nebius as a new provider with model selection and configuration support across the codebase.
nebius
as a new provider option inApiOptions.tsx
,ModelPicker.tsx
, andconstants.ts
.Nebius
component inproviders/Nebius.tsx
for handling Nebius-specific settings.useSelectedModel.ts
to support Nebius model selection.providerNames
andproviderSettingsSchema
inschemas/index.ts
to includenebius
.api.ts
.nebiusApiKey
invalidate.ts
.providerSettingsEntrySchema
andproviderSettingsSchemaDiscriminated
inschemas/index.ts
to includenebius
.MODELS_BY_PROVIDER
inconstants.ts
.This description was created by
for 8dc4ba8. You can customize this summary. It will automatically update as commits are pushed.