Skip to content

Fix/issue 5324 export button disabled #5849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

MuriloFP
Copy link
Collaborator

@MuriloFP MuriloFP commented Jul 17, 2025

fix: allow export task history while API is active (#5324)

Description

Fixes #5324

This PR restores the ability to export task history while the API is active, fixing a regression that prevented users from exporting partial task history during model operations.

Changes Made

  • Added exportAlwaysEnabled optional prop to TaskActions component with default value of false
  • Modified the export button to check exportAlwaysEnabled prop - when true, the button remains enabled regardless of buttonsDisabled state
  • Updated TaskHeader component to pass exportAlwaysEnabled={true} to TaskActions
  • Other action buttons (share, copy, delete) continue to respect the buttonsDisabled state as before

Testing

  • All existing tests pass
  • Added tests for the new exportAlwaysEnabled prop behavior
  • Manual testing completed:
    • Export button remains enabled during API operations
    • Export functionality works correctly while model is running
    • Other buttons are properly disabled during API operations

Verification of Acceptance Criteria

  • Export task history button is now enabled while API is active
  • Users can export partial task history during model operations
  • The fix addresses the regression from version 3.16.5

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic
  • Documentation updated (if needed)
  • No breaking changes (backward compatible with optional prop)
  • Accessibility checked (button states properly communicated)

Screenshots/Demo

Before: Export button shows 🚫 symbol and is disabled during API operations
After: Export button remains enabled and functional during API operations

Contact

@MuriloFP

@MuriloFP MuriloFP requested review from mrubens, cte and jr as code owners July 17, 2025 22:39
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jul 17, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 17, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 17, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 17, 2025
@KJ7LNW
Copy link
Collaborator

KJ7LNW commented Jul 18, 2025

tested, lgtm

@mrubens
Copy link
Collaborator

mrubens commented Jul 18, 2025

Is there a case where we don’t want export to be enabled?

@KJ7LNW
Copy link
Collaborator

KJ7LNW commented Jul 18, 2025

Is there a case where we don’t want export to be enabled?

I don't think so, this was a case of all the buttons being grouped with "Condense task context"

@daniel-lxs notes here: #5324 (comment)

This behavior was introduced in PR #3623 (commit c3716f1) which added the "Condense task context" feature. The PR modified the TaskActions component to accept a buttonsDisabled prop that controls all buttons uniformly, including the export button.

but really only "Condense task context" needed to be disabled during API reqs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PR - Needs Preliminary Review size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: PR [Needs Prelim Review]
Development

Successfully merging this pull request may close these issues.

regression: 'Export task history' is disabled while API is active
4 participants