-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix/issue 5324 export button disabled #5849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix/issue 5324 export button disabled #5849
Conversation
- Add exportAlwaysEnabled prop to TaskActions component - Export button remains enabled when exportAlwaysEnabled is true - Other action buttons still respect buttonsDisabled state - Add tests to verify the new behavior This fixes the regression where users couldn't export task history during API operations, which is a common debugging workflow.
tested, lgtm |
Is there a case where we don’t want export to be enabled? |
I don't think so, this was a case of all the buttons being grouped with "Condense task context" @daniel-lxs notes here: #5324 (comment)
but really only "Condense task context" needed to be disabled during API reqs. |
fix: allow export task history while API is active (#5324)
Description
Fixes #5324
This PR restores the ability to export task history while the API is active, fixing a regression that prevented users from exporting partial task history during model operations.
Changes Made
exportAlwaysEnabled
optional prop to TaskActions component with default value offalse
exportAlwaysEnabled
prop - when true, the button remains enabled regardless ofbuttonsDisabled
stateexportAlwaysEnabled={true}
to TaskActionsbuttonsDisabled
state as beforeTesting
exportAlwaysEnabled
prop behaviorVerification of Acceptance Criteria
Checklist
Screenshots/Demo
Before: Export button shows 🚫 symbol and is disabled during API operations
After: Export button remains enabled and functional during API operations
Contact
@MuriloFP