Skip to content

Update build.rs #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2023
Merged

Update build.rs #5

merged 1 commit into from
Aug 1, 2023

Conversation

qm3ster
Copy link
Contributor

@qm3ster qm3ster commented Jul 31, 2023

no-unused-parameter not supported on MSVC.
This makes it build for me.

Is there harm in making the rest conditional as well?

@qm3ster
Update build.rs
b52794f 
`no-unused-parameter` not supported on Windows
@RubixDev
Copy link
Owner

RubixDev commented Aug 1, 2023

Thanks! I didn't have them conditional since 9d76832 because when targeting wasm32-unknown-unknown the flags were falsely not applied even though they are supported. I have now investigated why that is and opened rust-lang/cc-rs#839, so we can make the flags conditional again.

@RubixDev RubixDev merged commit e43411b into RubixDev:main Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qm3ster @RubixDev