Skip to content

spirv_builder feature compile_codegen to disable building rustc_codegen_spirv #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 6, 2025

Conversation

Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Apr 27, 2025

See writeup at Rust-GPU/cargo-gpu#69

breaking change:

  • default MetadataPrintout changed from Full to None (controls printing of cargo::rerun-if-changed="path/to/file" for build script)

@Firestar99 Firestar99 force-pushed the compile_codegen_feature branch from 0f65bdd to 1c0baee Compare April 28, 2025 17:17
@Firestar99 Firestar99 force-pushed the compile_codegen_feature branch from db5a368 to 5235161 Compare April 29, 2025 13:55
@Firestar99 Firestar99 force-pushed the compile_codegen_feature branch from 436846c to b619665 Compare April 30, 2025 17:49
@Firestar99 Firestar99 force-pushed the compile_codegen_feature branch from 8790849 to b8f659b Compare April 30, 2025 19:50
@Firestar99
Copy link
Member Author

Firestar99 commented Apr 30, 2025

compile_codegen: include_str! all target_spec jsons for cargo gpu

this commit made my cargo fmt slow to an absolute crawl, needs investigation

ignore that, my IDE was just derpy I guess

@Firestar99 Firestar99 force-pushed the compile_codegen_feature branch from dd6961d to eca83df Compare April 30, 2025 21:34
@schell
Copy link
Contributor

schell commented Apr 30, 2025

This is looking great @Firestar99 , what's left?

@Firestar99
Copy link
Member Author

I'd wait and merge this PR together with Rust-GPU/cargo-gpu#69, in case I find something that still needs adjustment.

@Firestar99 Firestar99 force-pushed the compile_codegen_feature branch from f35e492 to 74d1c66 Compare May 1, 2025 13:28
@Firestar99 Firestar99 marked this pull request as ready for review May 1, 2025 13:47
@Firestar99 Firestar99 requested review from eddyb and LegNeato as code owners May 1, 2025 13:47
@Firestar99 Firestar99 requested a review from schell May 1, 2025 13:47
Copy link
Contributor

@schell schell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Firestar99
Copy link
Member Author

Something I forgot to mention here: The default MetadataPrintout changed from Full to None, so you now have to explicitly enable it to get cargo::rerun-if-changed="path/to/file" messages

@Firestar99 Firestar99 added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 6d7c1cd May 6, 2025
7 checks passed
@Firestar99 Firestar99 deleted the compile_codegen_feature branch May 6, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants