Skip to content

conditional passing of edition for core #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
est31 opened this issue May 16, 2025 · 0 comments
Open

conditional passing of edition for core #1163

est31 opened this issue May 16, 2025 · 0 comments

Comments

@est31
Copy link

est31 commented May 16, 2025

Since PR rust-lang/rust#138162, the Rust std library and core libraries use edition 2024. The Linux makefile hardcodes edition 2021 however.

Right now, core compiles fine on editions 2021 and 2024, but my PR rust-lang/rust#140966 encountered a build failure of the rust-for-linux CI.

Talked to @nbdd0121 about this. According to them, it should be possible to add conditional compilation dependent on the rust compiler used to compile the kernel. This matches the expectations of the core library the most I'd say: on releases before 1.87.0, the compiler used edition 2021, and on 1.87.0 and later, it uses 2024.

cc @ehuss

nbdd0121 added a commit to nbdd0121/linux that referenced this issue May 17, 2025
Rust 1.87 (released on 2025-05-15) compiles core library with edition
2024 instead of 2021 [1]. Ensure that the edition matches libcore's
expectation to avoid potential breakage.

Cc: [email protected] # Needed in 6.12.y and later (Rust is pinned in older LTSs).
Link: rust-lang/rust#138162 [1]
Closes: Rust-for-Linux#1163
Signed-off-by: Gary Guo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant