-
Notifications
You must be signed in to change notification settings - Fork 450
Remove unnecessary section on the quickstart doc #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary section on the quickstart doc #384
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Rustdoc is part of rustc component and we don't need an additional one. Signed-off-by: Yuki Okushi <[email protected]>
Review of
|
It is in the rustup default. But for example it is not always default in the NixOS env. So I would like to keep it. As it also has the note that per default it is installed. |
@kloenk As bjorn3 mentioned, all the profiles have the |
LGTM -- I would update https://github.com/rust-lang/rustup/blob/master/doc/src/concepts/components.md to clarify in which component |
What do you mean by:
in the commit message? |
I mean we don't need an additional component (i.e. |
That's fine :) |
Yes for rustup. My package manager provides a package for rustc, which only includes rustc and no rustdoc. I already got bitten by this once, as rustc and rustdoc had ben a different version. |
Hmm... That is a good point. I think we should mention it ( Let me think about it. |
I agree with this point, we treat Rustup as our recommend way to use Rust. If you want to see the specific instructions for rustdoc, then why not expand clippy and rustfmt sections as well. |
Side-note: Rustup may not be the recommended way for the kernel later on (e.g. when distributions package the required toolchain to build their kernel).
LGTM -- perhaps remove the very last sentence since we do not say it for others:
|
Rustdoc is part of rustc component and we don't need an additional one.
Signed-off-by: Yuki Okushi [email protected]