rust: linked_list: add usage example#937
Open
JoseExposito wants to merge 1 commit intoRust-for-Linux:rustfrom
Open
rust: linked_list: add usage example#937JoseExposito wants to merge 1 commit intoRust-for-Linux:rustfrom
JoseExposito wants to merge 1 commit intoRust-for-Linux:rustfrom
Conversation
Member
|
CI failure looks spurious. |
|
This looks like a great companion to I verified the doctests work with …and it worked fine. It also helped me understand the linked_list type, so clearly a success. So this is: One possible idea for the future (though whether or not it fits best here as a doctest, I'm not sure) would be to add an example for having the same object be an element of multiple lists. That seems like something that'd benefit from an example at some point. |
sulix
approved these changes
Dec 15, 2022
Illustrate how to use the linked list adding an example that uses all methods the linked list currently supports. Link: Rust-for-Linux#345 Reviewed-by: David Gow <davidgow@google.com> Signed-off-by: José Expósito <jose.exposito89@gmail.com>
JoseExposito
force-pushed
the
patch-rust-linked-list-examples
branch
from
329c4d2 to
4c6c989
Compare
Author
|
Thanks @sulix , I just added your reviewed-by :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Thanks for adding this "good first issue" tags, they are really useful to get started and start knowing the community members working on the project.
This PR addresses #345, adding and example that illustrates how to use the linked list using all of its methods.
I'm pretty new to Rust, so please feel free to point any issues. I'm looking forward to work on something a bit more difficult once I get some practice with the language.