Dev/ci fix #74
Merged
Dev/ci fix #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
BennoLossin
commented
Jul 23, 2025
BennoLossin
commented
- ci: fix test workflow
- ci: don't consider merge commits in the signed-off-by workflow
- ci: run normal ci on schedule
Use `allow` instead of fixing it, because `is_multiple_of` is unstable in 1.82 and the clippy warning doesn't exist before 1.90 (otherwise `expect` could have been used). Signed-off-by: Benno Lossin <[email protected]>
The `test` workflow only fetched the latest commit and thus only tested that one instead of the entire pull request. Signed-off-by: Benno Lossin <[email protected]>
Merge commits don't get a `Signed-off-by` tag. Signed-off-by: Benno Lossin <[email protected]>
Remove the schedule-only CI parts and make the normal CI run every day. Also keep the `update` workflow from the schedule-only one. Signed-off-by: Benno Lossin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.