Skip to content

Fix deprecation warnings #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MichaelHills
Copy link
Contributor

  • dyn trait
  • try!
  • mem::uninitialized

Not sure if I'm doing this right. macOS feedback example still runs though.

Copy link
Member

@simlay simlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelHills
Copy link
Contributor Author

That’s correct. Hmm is there a less invasive alternative I could have done for the Error description() change to use to_string() instead of changing the implementation of Display? Is it just replacing description with to_string?

@simlay
Copy link
Member

simlay commented Nov 30, 2020

That’s correct. Hmm is there a less invasive alternative I could have done for the Error description() change to use to_string() instead of changing the implementation of Display? Is it just replacing description with to_string?

I think this is okay. I'm not entirely sure what the documentation means with to_string (maybe impl String::from) but this seems okay to me.

@MichaelHills
Copy link
Contributor Author

Did further testing, forcing some errors out, seems like if main() returns Result, it'll log crashes with debug and not display. So I wrapped main to print the display string and it works for a couple of different errors I forced.

Still works on mac feedback + sine and iOS feedback.

@MichaelHills MichaelHills merged commit 56a183e into RustAudio:master Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants