Revert "signature: replace signature_derive with blanket impls (#1827)"
#1840
+887
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit bf47748. Per #1831 this change breaks inference when there is a single explicit impl of the `Signer` trait. It also wasn't possible to add corresponding blanket impls to the `Async*` traits, e.g. `AsyncSigner` for `AsyncDigestSigner`, because of the existing blanket impl of `AsyncSigner` for `Signer` which we definitely want to preserve. As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here. Closes #1831
|
Wait, which crates actually consumes the signature_derive again? |
|
@baloo I think most of the crates avoid it to avoid pulling in the proc macro stack (in which case maybe it's not a great solution) |
|
well where I'm trying to go is: maybe we can just pull the |
|
Sure |
|
This is actually used in yubihsm.rs! |
|
Yeah, that's probably the one thing that uses it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit bf47748.
Per #1831 this change breaks inference when there is a single explicit impl of the
Signertrait.It also wasn't possible to add corresponding blanket impls to the
Async*traits, e.g.AsyncSignerforAsyncDigestSigner, because of the existing blanket impl ofAsyncSignerforSignerwhich we definitely want to preserve.As a general rule of thumb, blanket impls only make sense if they work 100% of the time, which doesn't seem to be happening here.
Closes #1831