elliptic-curve: impl BatchInvert for NonZeroScalar
#1890
Merged
+104
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Jun 6, 2025
tarcieri
changed the title
BatchInvert for NonZeroScalarBatchInvert for NonZeroScalar
|
@daxpedda hmm, probably should've asked for a companion PR for this to https://github.com/RustCrypto/elliptic-curves for this, having a little trouble updating |
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jun 6, 2025
Companion PR to RustCrypto/traits#1890
|
Never mind, got it: RustCrypto/elliptic-curves#1234 |
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jun 6, 2025
Companion PR to RustCrypto/traits#1890
tarcieri
added a commit
to RustCrypto/elliptic-curves
that referenced
this pull request
Jun 6, 2025
Companion PR to RustCrypto/traits#1890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements
BatchInvertforNonZeroScalar.To accomplish this, I did the following notable things:
BatchInvertitself.CtOptionfromBatchInvert::batch_inverts return type.invert_batch_internal()internally, which now takes aninvertfunction instead of requiringtrait Invert.MulAssignforNonZeroScalar.Things that could still be added:
BatchInvertimplementations onScalar, I left the ones taking a reference to a slice out.MulAssignforNonZeroScalaron more combinations.It might be a tiny bit simpler if I implemented
DefaultonNonZeroScalar, but that seemed like a footgun to me.