cipher: add methods for writing keystream #1907
Merged
+75
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazar-pc
reviewed
Jun 18, 2025
| /// If end of the keystream will be reached with the given data length, | ||
| /// method will panic without modifying the provided `data`. | ||
| #[inline] | ||
| fn write_keystream(&mut self, buf: &mut [u8]) { |
There was a problem hiding this comment.
Any strong reason to prefer &mut [u8] over &mut [MaybeUninit<u8>]? That is exactly the type that Vec::spare_capacity_mut() returns and I'd rather not rely on compiler guessing and removing extra zeroing.
In fact the method could me something like this:
fn write_keystream(&mut self, buf: &mut [MaybeUninit<u8>]) -> &mut [u8] {Where return type is buf with bytes filled in.
There was a problem hiding this comment.
We try to minimize amount of unsafe code in our crates and usually in practice bothering with MaybeUninit<u8> is not worth the trouble, especially with code like this which is very easy for the compiler to remove unnecessary buffer zeroization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes RustCrypto/stream-ciphers#424