Skip to content

Xcode 10.1 & Circle CI v2 #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 28, 2019
Merged

Xcode 10.1 & Circle CI v2 #180

merged 9 commits into from
Feb 28, 2019

Conversation

bobgodwinx
Copy link
Member

Summary

This is fixing issue #155 and #179

  • Update the project and xcworkspace and make it compatible with Version 10.1 (10B61)
  • Update the Unit test target and make it compatible with Version 10.1 (10B61)
  • Moving to circle CI 2.0

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'll put my green when CI passes

circle.yml Outdated
XCODE_TEST_REPORTS: /tmp/xcode-test-results
LANG: en_US.UTF-8
macos:
xcode: '10.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be

Suggested change
xcode: '10.1'
xcode: '10.1.0'

See here @bobgodwinx :
https://discuss.circleci.com/t/xcode-10-1-image-released/26350

Copy link
Member

@freak4pc freak4pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏

@freak4pc freak4pc merged commit a089696 into master Feb 28, 2019
@freak4pc freak4pc deleted the develop branch February 28, 2019 23:04
@freak4pc freak4pc mentioned this pull request Feb 28, 2019
@freak4pc freak4pc changed the title Develop Xcode 10.1 & Circle CI v2 Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants