Not replay executionObservables for execute() #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found second call of
execute()
returns the same output which the first time returned.This issue started to happen from version 2.1.0, and doesn't happen when one use
input
only.This issue is caused by replaying execution observable. To fix this issue, this PR replaces
sharedReplay(1)
ofexecutionObservable
withshare()
so thatexecute()
returns always return the latest execution observable.I'm sorry for overlooking this issue.
I've also update unit tests to detect the same kind of issue.