Some features from the PR #197 (PR splitted)#225
Merged
Conversation
pitbulk
commented
Apr 29, 2015
pitbulk
commented
Collaborator
- Comment the code.
- Remove spaces and format some lines.
- Remove unnecessary errors method.
- Improve format_cert and format_private_key.
- Fix xpath injection on xml_security.rb
* Comment the code * Remove spaces and format some lines * Remove unnecesary errors method
Collaborator
Author
|
@luisvm @daniel-g @Lordnibbler can I merge it? |
Contributor
There was a problem hiding this comment.
will this contain an array of Strings/Objects?
Collaborator
Author
There was a problem hiding this comment.
I was only adding comments on this PR, the code on master is without the =.
Notice that the attribute is index, and we named the setter service_index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.