Skip to content

update scp1 #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 14, 2022
Merged

update scp1 #422

merged 6 commits into from
Nov 14, 2022

Conversation

huber-nicolas
Copy link
Contributor

No description provided.

@huber-nicolas huber-nicolas requested a review from wurzka November 2, 2022 17:17
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@huber-nicolas
Copy link
Contributor Author

@schneidermic0 I just realised that this example is very big. It has 166 thousand rows. Do we need such a big example?

@schneidermic0
Copy link
Contributor

@schneidermic0 I just realised that this example is very big. It has 166 thousand rows. Do we need such a big example?

I guess this we have to discuss with the object type owners. I guess we can reduce it. ;)

However, this should not hinder you merge this PR. This can be also updated in a separate PR.

Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huber-nicolas huber-nicolas merged commit 9d41a6d into main Nov 14, 2022
@huber-nicolas huber-nicolas deleted the scp1 branch November 14, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants