feat: Update github actions to handle orchestration spec updates#1542
feat: Update github actions to handle orchestration spec updates#1542BrigittaK307 wants to merge 4 commits intomainfrom
Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request:
feat: Update GitHub Actions to handle orchestration spec updatesNew Features✨ Enhanced the spec file update cron job to automatically handle orchestration service specification updates alongside existing AI API, document grounding, and prompt registry updates. The workflow now dynamically fetches orchestration versions and triggers appropriate spec updates. Changes
GitHub Issues
PR Bot InformationVersion:
|
There was a problem hiding this comment.
Please match this logic instead (but maybe use yq):
https://github.com/SAP/ai-sdk-java/blob/main/.github/workflows/weekly-spec-update.yaml#L27-L50
This should match the actual service version, also not every tag has a release.
There was a problem hiding this comment.
I feel like it should error in this case so it can send a slack notification.
| ORCH_VERSION=$(curl --silent --request GET \ | ||
| --url "https://github.tools.sap/api/v3/repos/MLF-prod/mlf-gitops-prod/contents/services/llm-orchestration/source/Chart.yaml?ref=aws.eu-central-1.prod-eu/current" \ | ||
| -H "Authorization: Bearer $TOKEN" \ | ||
| -H "Accept: application/vnd.github.v3.raw" | grep 'version:' | awk '{print $2}') |
There was a problem hiding this comment.
[pp]
| -H "Accept: application/vnd.github.v3.raw" | grep 'version:' | awk '{print $2}') | |
| -H "Accept: application/vnd.github.v3.raw" | yq -r .version) |
| gh workflow run spec-update.yaml \ | ||
| --field file=${{ matrix.file }} \ |
There was a problem hiding this comment.
[pp] Doesn't hut keeping this verbose:
| gh workflow run spec-update.yaml \ | |
| --field file=${{ matrix.file }} \ | |
| gh workflow run spec-update.yaml \ | |
| --ref main \ | |
| --field file=${{ matrix.file }} \ |
| fi | ||
| echo "Using branch: $BRANCH" |
There was a problem hiding this comment.
Please preserve the existing/commented RPT update script somewhere, either as a step like orchestration or here in 'Trigger spec update'.
TAG=$(git -c 'versionsort.suffix=-' ls-remote --tags --sort='v:refname' https://github.tools.sap/DL-COE/sap-rpt-1-public-content | tail --lines=1 | cut -f 2)
Context
Closes SAP/ai-sdk-js-backlog#478
What this PR does and why it is needed
Modified cron job to handle orchestration spec updates, too.
The changes should be aligned with what the Java team implemented.