Conversation
SummaryThe following content is AI-generated and provides a summary of the pull request: Add API Documentation Generation Workflow🔧 Chore: Automated API Documentation GenerationThis PR introduces automated API documentation generation using TypeDoc, enabling automatic publishing of API reference documentation to the SAP/ai-sdk repository. ChangesDocumentation Generation
CI/CD Integration
Dependencies
GitHub Issues
PR Bot InformationVersion:
💌 Have ideas or want to contribute? Create an issue and share your thoughts with us! Made with ❤️ by Hyperspace. |
scripts/generate-docs.ts
Outdated
There was a problem hiding this comment.
[pp] Mark node imports with node:fs. That makes it easier to differentiate from other imports + it is more secure.
[pp] I would prefer if we could apply the async functions instead of the sync ones.
There was a problem hiding this comment.
I changed the implementation accordingly. Should I also do the similar changes in other script files in this PR?
marikaner
left a comment
There was a problem hiding this comment.
Generally looks good, I guess this is taken from Cloud SDK right? I have some small questions...
scripts/generate-docs.ts
Outdated
There was a problem hiding this comment.
[req] Can't we do something like this:
| htmlPaths.map((filePath: string) => removeUnderlinePrefixFromFileName(filePath)) | |
| htmlPaths.map((filePath: string) => { | |
| const newPath = removeUnderlinePrefix(filePath); | |
| return rename(filePath, newPath) | |
| }) |
There was a problem hiding this comment.
I think it has a little different functioning here. Because we don't remove the first underscore from the filePath, rather the leading underscores from the fileName. (i.e. path/_fileName -> path/fileName). But I can still reuse the function removeUnderlinePrefix there as you suggested.
Context
Closes SAP/ai-sdk-js-backlog#453.
What this PR does and why it is needed