Provide Dynatrace Exporter #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a DynatraceMetricsExporter to the provided exporters. This exporter will parse CF bindings for a Dynatrace service binding. If found, it will export metrics to the API endpoint. For this to work, the API token field in the service credentials needs to be provided with `otel.javaagent.extension.sap.cf.binding.dynatrace.metrics.token-name`. Several refacotrings align Dynatrace and Cloud Logging exporters. Signed-off-by: Karsten Schnitter <[email protected]>
Signed-off-by: Karsten Schnitter <[email protected]>
Use the correct protocol and header to send data to Dynatrace. Extend the sample manifest by Dynatrace configuration. Signed-off-by: Karsten Schnitter <[email protected]>
cf-java-logging-support-opentelemetry-agent-extension/README.md
Outdated
Show resolved
Hide resolved
Comment on lines
76
to
77
| The difference between `cloud-logging` and `otlp` exporters are explained in an own [section](#implementation-differences-between-cloud-logging-and-otlp-exporter). | ||
| The benefit of the `cloud-logging` exporter is, that it can be combined with a different configuration of the `otlp` exporter. |
There was a problem hiding this comment.
I would assume this also applies for Dynatrace, right?
There was a problem hiding this comment.
No, there is no default configuration for the otlp exporter and Dynatrace. You need to use the dynatrace exporter explicitly. Note, that otlp is considered to be a legacy/fallback approach. Since Cloud Logging is always available, it is used as the default.
Comment on lines
+23
to
+25
| public CloudLoggingServicesProvider(ConfigProperties config) { | ||
| this(config, new CloudFoundryServicesAdapter(new CfEnv())); | ||
| } |
There was a problem hiding this comment.
Like the simplification that comes from the refactoring
| Map<String, String> properties = propertiesSupplier.get(); | ||
|
|
||
| assertTrue(properties.isEmpty()); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } | |
Missing new line :-)
...com/sap/hcf/cf/logging/opentelemetry/agent/ext/binding/CloudLoggingServicesProviderTest.java
Show resolved
Hide resolved
Signed-off-by: Karsten Schnitter <[email protected]>
juergen-walter
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a DynatraceMetricsExporter to the provided exporters. This exporter will parse CF bindings for a Dynatrace service binding. If found, it will export metrics to the API endpoint. For this to work, the API token field in the service credentials needs to be provided with
otel.javaagent.extension.sap.cf.binding.dynatrace.metrics.token-name.Several refacotrings align Dynatrace and Cloud Logging exporters.