EXPERIMENT(Devconatiner): Adding devcontainer setup#365
EXPERIMENT(Devconatiner): Adding devcontainer setup#365
Conversation
SatabdiG
added
the
do-not-merge
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
SatabdiG
changed the title
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
SatabdiG
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
sdischer-sap
left a comment
sdischer-sap
left a comment
There was a problem hiding this comment.
Thats super promising and a real nice addition to easing the onboarding.
I wasn't aware of this codespaces flow before. Do you mind showcasing this in the next dev sync?
.devcontainer/setup.sh
Outdated
There was a problem hiding this comment.
Do we have a need for that? I never used the CLI. Just curious.
There was a problem hiding this comment.
So my thinking for this was, maybe a user would like to do
kubectl crossplane install provider ghcr.io/sap/crossplane-provider-btp:latest
Then the cli needs to be there. Else, we can have the user create a examples/provider.yaml file and use kubectl apply -f, but I think the CLI command could be useful for someone who just wants to just take our provider for a spin.
There was a problem hiding this comment.
Cool. Totally makes sense. I wasn't aware of that option.
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
I would love to, if there is nothing pressing. |
sdischer-sap
left a comment
sdischer-sap
left a comment
There was a problem hiding this comment.
Really cool stuff here. Thanks for all the feedback. LGTM
.devcontainer/setup.sh
Outdated
There was a problem hiding this comment.
Cool. Totally makes sense. I wasn't aware of that option.
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
|
SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly. If you thing this is wrong or need any assistance, please contact ospo@sap.com. |
SatabdiG
had a problem deploying
to
pr-e2e-approval
GitHub Actions
Failure
| "\"password\":" | ||
| "credentials.*:.*{" | ||
| "BEGIN.*PRIVATE KEY" | ||
| "authentication.sap.hana.ondemand.com" |
| # INSTALL CLI TOOLS | ||
| # ============================================================================= | ||
|
|
||
| # kind |
There was a problem hiding this comment.
Pin versions, maybe have checksums as well
|
|
||
| if echo | timeout 10 openssl s_client -showcerts \ | ||
| -connect authentication.sap.hana.ondemand.com:443 2>/dev/null | \ | ||
| awk '/BEGIN CERTIFICATE/,/END CERTIFICATE/ {print}' > /tmp/sap-certs.pem 2>/dev/null && \ |
There was a problem hiding this comment.
Maybe create a log file for errors, for troubleshooting
| configure_credentials() { | ||
| local namespace="default" | ||
|
|
||
| if [ -n "$BTP_TECHNICAL_USER" ] && [ -n "$CIS_CENTRAL_BINDING" ]; then |
There was a problem hiding this comment.
Maybe check if these variables are valid jsons
SatabdiG
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
SatabdiG
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
3 participants
Experimental branch for devcontainer