Skip to content

Feat/create/convert eslint config#4155

Open
heimwege wants to merge 20 commits intomainfrom
feat/create/convert-eslint-config
Open

Feat/create/convert eslint config#4155
heimwege wants to merge 20 commits intomainfrom
feat/create/convert-eslint-config

Conversation

@heimwege
Copy link
Contributor

@heimwege heimwege commented Feb 16, 2026

Add a new command create convert eslint-config that converts an existing eslint config of a project that is below eslint version 9 to eslint version 9.
It also adds/upgrades @sap-ux/eslint-plugin-fiori-tools and removes eslint-plugin-fiori-custom.

Additionally

  • adds skipInstall option to add eslint-config
  • refactors require.resolve to get eslint mjs template in add eslint-config
  • fixed create README generator to only show 'required' for required command options (no longer for optional command options with required values).

@heimwege heimwege added create @sap-ux/create app-config-writer @sap-ux/app-config-writer labels Feb 16, 2026
@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2026

🦋 Changeset detected

Latest commit: d8a5768

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux/app-config-writer Patch
@sap-ux/create Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heimwege heimwege requested a review from lfindlaysap February 18, 2026 10:30
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const MIGRATION_ERROR_TEXT = `Migration to eslint version 9 failed. Please check if you can find more details above. You might want to check the official eslint documentation on how to migrate to version 9: https://eslint.org/docs/latest/use/migrate-to-9.0.0#flat-config or delete the existing eslint \`devDependency\` and run \`create add eslint\` to get a flat config eslint.config.mjs where you can transfer your old eslint config manually.`;
const MIGRATION_ERROR_TEXT = `Migration to eslint version 9 failed. Check if there are error messages above. You can also delete the existing eslint \`devDependency\` and run \`create add eslint\` to create a eslint.config.mjs file with the flat config where you can transfer your old eslint config manually.` For more information, see [https://eslint.org/docs/latest/use/migrate-to-9.0.0#flat-config](Migrate to v9.x).;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`EsLint version is already 9.0.0 or higher in this project. Found 'eslint' dependency with version '${packageJson.devDependencies?.eslint}' in package.json at path '${packageJsonPath}'`
`ESLint version is already 9.0.0 or higher in this project. Found 'eslint' dependency with version '${packageJson.devDependencies?.eslint}' in package.json at path '${packageJsonPath}'`

Copy link
Contributor Author

@heimwege heimwege Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

29ee957

Also I adjustes other occurrences of eslint to ESLint

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`\`npm install\` will be skipped. Please make sure to install the dependencies before executing any linting commands.`
`\`npm install\` was skipped. Ensure you install the dependencies before executing any linting commands.`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in 29ee957

@heimwege heimwege marked this pull request as ready for review February 18, 2026 13:59
@heimwege heimwege requested a review from a team as a code owner February 18, 2026 13:59
@heimwege heimwege requested review from devinea February 18, 2026 14:33
@heimwege heimwege requested a review from a team as a code owner February 19, 2026 12:55
@heimwege heimwege added the ui5-application-writer @sap-ux/ui5-application-writer label Feb 19, 2026
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app-config-writer @sap-ux/app-config-writer create @sap-ux/create ui5-application-writer @sap-ux/ui5-application-writer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments