Skip to content

chore: bump-schematics-deps #21009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pucek9 merged 13 commits into from
Jan 14, 2026
Merged

chore: bump-schematics-deps #21009

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ab35f02
init
Pucek9 Jan 14, 2026
8f0defb
chore/CXSPA-11875: fix esm issues
Pucek9 Jan 14, 2026
f793acf
chore/CXSPA-11875: use more strict regexp and config preset
Pucek9 Jan 14, 2026
3f4cc00
chore/CXSPA-11875: prettier
Pucek9 Jan 14, 2026
e512bf5
Merge branch 'develop-next-major' of github.com:SAP/spartacus into ch…
Pucek9 Jan 14, 2026
eace718
chore/CXSPA-11875: fix duplicated esmPackages array
Pucek9 Jan 14, 2026
4918bef
Add license header
github-actions[bot] Jan 14, 2026
82581d9
chore/CXSPA-11875: change packages to matchers
Pucek9 Jan 14, 2026
2e07e49
Merge remote-tracking branch 'origin/chore/CXSPA-11875' into chore/CX…
Pucek9 Jan 14, 2026
dae92bc
chore/CXSPA-11875: cleanup
Pucek9 Jan 14, 2026
ed28d27
Merge branch 'develop-next-major' into chore/CXSPA-11875
Pucek9 Jan 14, 2026
dbf6202
Trigger Build
Pucek9 Jan 14, 2026
f706e2e
chore/CXSPA-11875: use older npm version
Pucek9 Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions feature-libs/asm/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],
Copy link
Copy Markdown
Contributor

@Platonn Platonn Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[QUESTION]
I can understand this line allows to transform just parse5 and @angular inside node_modules (rest of node_modules is not transformed).

Why do we need to add this config property at all?

  1. why do we need to transform parse5? I can see in major version 8.0 they changed to ESM-only feat: switch to ESM-only inikulin/parse5#1411 . But I'm still lacking understanding why would it (or something else?) imply that we have to transform it?
  2. Why did you add @angular to the transform allow-list? To my limited understanding, before this PR, @angular was ignored from transforming (as part of implicit default ignoring of all node_modules.

Copy link
Copy Markdown
Contributor

@Platonn Platonn Jan 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've investigated answers to those questions and eventually I'd suggest the following code snippet:

Suggested change
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],
transformIgnorePatterns: [
// Because ESM support is experimental in Jest, we don't enable it
// So Jest has to transform ESM files inside node_modules.
// For more see Jest docs: https://jestjs.io/docs/ecmascript-modules
//
// Due to a negative lookahead, we need to compose 2 patterns into one:
// - Original pattern `node_modules/(?!(.*\\.mjs$|@angular/common/locales/.*\\.js$))` - copied from jest-preset-angular sources
// see https://github.com/thymikee/jest-preset-angular/blob/8b7673ee739919433b0834fe4a3f55862801bd40/src/presets/create-cjs-preset.ts#L22
// - Custom pattern `node_modules/(?!parse5)` - because in parse5@18.0.0 became an ESM-only package
`node_modules/(?!(.*\\.mjs$|@angular/common/locales/.*\\.js$)|parse5)`,
],

My reasoning below:

I've tried removing this config on local in this PR branch and I can see the error:


    Jest encountered an unexpected token

    Jest failed to parse a file. This happens e.g. when your code or its dependencies use non-standard JavaScript syntax, or when Jest is not configured to support such syntax.

    Out of the box Jest supports Babel, which will be used to transform your files into valid JS based on your Babel configuration.

    By default "node_modules" folder is ignored by transformers.

    Here's what you can do:
     • If you are trying to use ECMAScript Modules, see https://jestjs.io/docs/ecmascript-modules for how to enable it.
     • If you are trying to use TypeScript, see https://jestjs.io/docs/getting-started#using-typescript
     • To have some of your "node_modules" files transformed, you can specify a custom "transformIgnorePatterns" in your config.
     • If you need a custom transformation, specify a "transform" option in your config.
     • If you simply want to mock your non-JS modules (e.g. binary assets) you can stub them out with the "moduleNameMapper" config option.

    You'll find more details and examples of these config options in the docs:
    https://jestjs.io/docs/configuration
    For information about custom transformations, see:
    https://jestjs.io/docs/code-transformation

    Details:

    /Users/krzysztof/code/classic-help-2/node_modules/parse5/dist/index.js:1
    import { Parser } from './parser/index.js';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      1 | import { SchematicsException, Tree } from '@angular-devkit/schematics';
    > 2 | import { DefaultTreeAdapterMap, parse as parseHtml } from 'parse5';
        | ^

I'd go for enabling enable ESM support in Jest, instead of transforming it, but only then I learned in the Jest docs ESM support is experimental. So better not use it for testing. 👍

Regarding 1) I find it justified then to transform parse5
Regarding 2) I find it justified to ignore also @angular, but not all of it. Learned that by overriding the whole property transformIgnorePatterns, we've overriden the default of the jest-preset-angular which was defined as this. The original pattern is more sophisticated. I wondered maybe we could compose both patterns as an array, but due to negative lookahead with AND operator it didn't work as expected. I mean I tried:

const { createCjsPreset } = require('jest-preset-angular/presets');
const cjsAngularPreset = createCjsPreset();
/*...*/
transformIgnorePatterns: [
    ...cjsAngularPreset.transformIgnorePatterns,
    'node_modules/(?!parse5)',
  ],

and then one of those folders was ignored (while it shouldn't). This gotcha is described also in Jest docs

So eventually we need to compose "manually" those 2 patterns (the original from jest-preset-angualr and our custom one for parse5).
And IMHO we should add a code comment with explanation, as it's not obvious for a future newcomer developer why such a pattern.

Copy link
Copy Markdown
Contributor Author

@Pucek9 Pucek9 Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Platonn for the deeper analysis!
Indeed, the pattern transformIgnorePatterns: ['node_modules/(?!parse5|.*\\.mjs$|@angular/common/locales/.*\\.js$)'], also works


collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/cart/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/checkout/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/customer-ticketing/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/estimated-delivery-date/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/order/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/organization/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/pdf-invoices/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/pickup-in-store/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/product-configurator/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/product-multi-dimensional/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/product/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/qualtrics/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/quote/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/requested-delivery-date/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/smartedit/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/storefinder/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/subscription-billing/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/tracking/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions feature-libs/user/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/cdc/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/cdp/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/cds/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/cpq-quote/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/digital-payments/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/epd-visualization/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/omf/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/opf/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/opps/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/punchout/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/s4-service/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/s4om/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
1 change: 1 addition & 0 deletions integration-libs/segment-refs/jest.schematics.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ module.exports = {
},
],
},
transformIgnorePatterns: ['node_modules/(?!parse5|@angular)'],

collectCoverage: false,
coverageReporters: ['json', 'lcov', 'text', 'clover'],
Expand Down
Loading
Loading