Skip to content

feat: add mediaApiPrefix env var and backend.media.prefix config#21096

Open
uroslates wants to merge 7 commits intodevelopfrom
feature/CXSPA-12006-media-prefix
Open

feat: add mediaApiPrefix env var and backend.media.prefix config#21096
uroslates wants to merge 7 commits intodevelopfrom
feature/CXSPA-12006-media-prefix

Conversation

@uroslates
Copy link
Contributor

@uroslates uroslates commented Jan 30, 2026

Closes: https://jira.tools.sap/browse/CXSPA-12005

Adding

  • new Spartacus backend.media.prefix (hidden behind enableMediaPrefix feature flag) - similar to backend.occ.prefix. The new config is used when constructing the media baseUrl (added to the configured host as suffix === uri).
  • new Spartacus environment(-prod).ts file via mediaBaseUrl and mediaApiPrefix used for configuring backend.media.baseUrl and backend.media.prefix respectively.

@uroslates uroslates requested a review from a team as a code owner January 30, 2026 08:18
@github-actions github-actions bot marked this pull request as draft January 30, 2026 08:18
@uroslates uroslates marked this pull request as ready for review January 30, 2026 17:38
@cypress
Copy link

cypress bot commented Jan 30, 2026

spartacus    Run #51892

Run Properties:  status check passed Passed #51892  •  git commit 39c94ecbe1 ℹ️: Merge 1e3be044b59ca8536e40957157ee7639f220f2d9 into e8e85b0dc9df49128d97da0599e7...
Project spartacus
Branch Review feature/CXSPA-12006-media-prefix
Run status status check passed Passed #51892
Run duration 03m 33s
Commit git commit 39c94ecbe1 ℹ️: Merge 1e3be044b59ca8536e40957157ee7639f220f2d9 into e8e85b0dc9df49128d97da0599e7...
Committer Uros Lates
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 4
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 101
View all changes introduced in this branch ↗︎

@StanislavSukhanov StanislavSukhanov self-requested a review February 3, 2026 10:04
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @uroslates great job! Left some comments/suggestions

@github-actions github-actions bot marked this pull request as draft February 3, 2026 11:38
@uroslates uroslates marked this pull request as ready for review February 3, 2026 11:38
@github-actions github-actions bot marked this pull request as draft February 3, 2026 14:46
@uroslates uroslates marked this pull request as ready for review February 3, 2026 14:49
@github-actions github-actions bot marked this pull request as draft February 3, 2026 15:24
@uroslates uroslates marked this pull request as ready for review February 3, 2026 15:25
Copy link
Contributor

@StanislavSukhanov StanislavSukhanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit.

@github-actions github-actions bot marked this pull request as draft February 19, 2026 07:15
@uroslates uroslates marked this pull request as ready for review February 19, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments