WIP: spike - vite dev server for SSR#21122
Open
Platonn wants to merge 1 commit intorelease/221121.7.xfrom
Open
WIP: spike - vite dev server for SSR#21122Platonn wants to merge 1 commit intorelease/221121.7.xfrom
Platonn wants to merge 1 commit intorelease/221121.7.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working PoC of vite dev server with SSR:
noSsrfrom target"serve"instorefrontapp/project.jsonres.render()methodimport 'zone.js/plugins/zone-error'fromenvironment.ts(as it caused errors; and this code seems not needed anyway)How to run
SERVER_REQUEST_ORIGIN=http://localhost:4200 NODE_TLS_REJECT_UNAUTHORIZED=0 npm run startCaveats:
SERVER_REQUEST_ORIGIN=http://localhost:4200 NODE_TLS_REJECT_UNAUTHORIZED=0 npm run start)Next steps:
outputMode: serverinstorefrontapp/project.jsonfor the targetbuildand then fixing build issues