Skip to content

chore(ui5-tab-container): migrate tests to Cypress #11737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kskondov
Copy link
Contributor

migrates tab container tests to Cypress
JIRA: BGSOFUIRODOPI-3462

migrates tab container tests to Cypress
JIRA: BGSOFUIRODOPI-3462
@kskondov kskondov requested a review from a team June 16, 2025 11:42
Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete the old .spec file

Copy link
Contributor

@LidiyaGeorgieva LidiyaGeorgieva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 test failings:

  1. tests if content is scrollable when tab-container takes limited height by its parent
    error: assert expected 299.9884338378906 to be at least 300
  2. test sub items selection
    error: Timed out retrying after 4050ms: cy.click() failed because this element is not visible:

@kskondov kskondov requested review from LidiyaGeorgieva and a team June 23, 2025 08:37
Copy link
Contributor

@dimovpetar dimovpetar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of warnings in the console for attributes usages. Replace them with properties in order to benefit from type checking

@kskondov kskondov requested a review from dimovpetar June 26, 2025 15:58
@duygu-rmdn duygu-rmdn requested a review from a team June 27, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants