🧪 Migrate to Awesome Assertions #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmackay
changed the title
danielmackay
changed the title
danielmackay
changed the title
danielmackay
requested review from
AntPolkanov,
MattParkerDev,
lukecookssw and
wicksipedia
MattParkerDev
approved these changes
Mar 25, 2025
AntPolkanov
approved these changes
Mar 25, 2025
lukecookssw
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to migrate from FluentAssertions to Awesome Assertions, update the build process, and modify test projects accordingly. The most important changes include updating the build command, modifying package references, and adjusting test assertion implementations.
See ADR
Figure: Majority of the SAW team are in favor of this change
Migration to Awesome Assertions:
Directory.Packages.props: AddedAwesomeAssertionspackage and removedFluentAssertionspackage. [1] [2]docs/adr/20250326-migrate-to-awesome-assertions.md: Added a new ADR document outlining the decision to migrate to Awesome Assertions.tests/Architecture.Tests/Architecture.Tests.csproj,tests/Domain.UnitTests/Domain.UnitTests.csproj,tests/WebApi.IntegrationTests/WebApi.IntegrationTests.csproj: Updated test projects to includeAwesomeAssertionsand removeFluentAssertions. [1] [2] [3]tests/Architecture.Tests/Common/TestResultAssertions.cs,tests/Architecture.Tests/Common/TestResultExtensions.cs: Modified test assertion implementations to useAssertionChainfrom Awesome Assertions. [1] [2] [3]Build process update:
.github/workflows/publish-log4brains.yml: Updated thelog4brains buildcommand to include the--basePathoption.